RFR: 8376760: VerifyJimage.java#compare intermittent failed with fastdebug [v2]

SendaoYan syan at openjdk.org
Sun Feb 1 02:11:45 UTC 2026


On Sat, 31 Jan 2026 17:15:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use ExecutorService.close() instead of ExecutorService.shutdown()/ExecutorService.awaitTermination()
>
> test/jdk/tools/jimage/VerifyJimage.java line 152:
> 
>> 150:                 long timeout = Utils.adjustTimeout(20);
>> 151:                 if (!pool.awaitTermination(timeout, TimeUnit.SECONDS)) {
>> 152:                     failed.add("Directory verification timed out in " + timeout + " seconds");
> 
> The alternative is to just replace the shutdown + awaitTermination with a call to `pool.close()`. This will wait indefinitely, which is useful for diagnosability if the verification hangs.

Thanks. The shutdown/awaitTermination has been replaced as ExecutorService.close(). The catch InterruptedException do not needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29498#discussion_r2750394856


More information about the core-libs-dev mailing list