RFR: 8376760: VerifyJimage.java#compare intermittent failed with fastdebug [v2]

Alan Bateman alanb at openjdk.org
Sun Feb 1 08:23:02 UTC 2026


On Sun, 1 Feb 2026 02:11:44 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> Test tools/jimage/VerifyJimage.java#compare intermittent timed out with fastdebug build. I think it would be better to ajust the jtreg timeout factor(20*timeoutFactor) rather that set the fix timeout value(20) for awaitTermination.
>> 
>> The test run all passed 100 times simultaneously.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use ExecutorService.close() instead of ExecutorService.shutdown()/ExecutorService.awaitTermination()

test/jdk/tools/jimage/VerifyJimage.java line 26:

> 24: import jdk.internal.jimage.BasicImageReader;
> 25: import jtreg.SkippedException;
> 26: import jdk.test.lib.Utils;

Using ExecutorService::close makes it simpler, good.

I assume this import is left over from one of the iterations where you were adjusting the timeout.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29498#discussion_r2750736340


More information about the core-libs-dev mailing list