RFR: 8377116: Refactor java/util/zip TestNG tests to JUnit [v2]
Justin Lu
jlu at openjdk.org
Wed Feb 4 18:58:44 UTC 2026
> This PR consists of a conversion for the java/util/zip TestNG tests to JUnit. Changes are mainly automated. https://github.com/openjdk/jdk/commit/1aeb8a634b8f255853516015f4b39bd79dd94090 is required to resolve a failure since JUnit parameterized tests automatically close arguments that implement `AutoCloseable`.
>
> Test stats before:
> Framework-based tests: 274 = 107 TestNG + 167 JUnit
>
> Test stats after:
> Framework-based tests: 274 = 0 TestNG + 274 JUnit
Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
- Fixing other 'DataProvider' occurrences in JUnit tests under java/util/zip
- Correct previous incorrect placement of actual/expected in assertions (Chen)
- Use static imports everywhere + fix 'DataProvider' in comments (Alan, Lance)
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29552/files
- new: https://git.openjdk.org/jdk/pull/29552/files/2d14b660..fc5f5cc4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29552&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29552&range=00-01
Stats: 45 lines in 8 files changed: 5 ins; 4 del; 36 mod
Patch: https://git.openjdk.org/jdk/pull/29552.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29552/head:pull/29552
PR: https://git.openjdk.org/jdk/pull/29552
More information about the core-libs-dev
mailing list