RFR: 8377116: Refactor java/util/zip TestNG tests to JUnit [v2]

Justin Lu jlu at openjdk.org
Wed Feb 4 18:58:47 UTC 2026


On Wed, 4 Feb 2026 15:34:47 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fixing other 'DataProvider' occurrences in JUnit tests under java/util/zip
>>  - Correct previous incorrect placement of actual/expected in assertions (Chen)
>>  - Use static imports everywhere + fix 'DataProvider' in comments (Alan, Lance)
>
> test/jdk/java/util/zip/GZIP/GZIPOutputStreamHeaderTest.java line 25:
> 
>> 23: 
>> 24: 
>> 25: import org.junit.jupiter.api.Assertions;
> 
> Can we import the specific methods to be consistent with the other tests

https://github.com/openjdk/jdk/pull/29552/commits/1fae2628d5bcfa9915a80c33060aca71060d7607 standardizes the imports and cleans up 'DataProvider' in the comments as you and Alan pointed out. https://github.com/openjdk/jdk/pull/29552/commits/fc5f5cc449b93a50a0e14c39d0ef28f01404026c also addresses other instances of 'DataProvider' (outside of the initial scope of files changed).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29552#discussion_r2765528459


More information about the core-libs-dev mailing list