RFR: 8375285: Port fdlibm asinh to Java [v9]
Anton Artemov
aartemov at openjdk.org
Tue Feb 10 09:14:43 UTC 2026
On Tue, 10 Feb 2026 02:41:20 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Anton Artemov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8375285: Addressed reviewer's comments.
>
> test/jdk/java/lang/StrictMath/HyperbolicTests.java line 511:
>
>> 509: {0x1.ffffffffffffep-19, 0x1.fffffffffaaa9p-19},
>> 510: {0x1.fffffffffffffp-18, 0x1.ffffffffeaaa9p-18},
>> 511: {0x1p-17, 0x1.ffffffffeaaabp-18},
>
> Nit: I'd prefer if the second values were all aligned even if the first argument didn't take that many characters to initialize.
Noted!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29273#discussion_r2786732766
More information about the core-libs-dev
mailing list