RFR: 8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java [v2]

[Justin Lu]

On Tue, 6 Jan 2026 23:17:22 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   parameterize the rest of tests and resolve setup conflicts
>
> test/jdk/java/time/tck/java/time/AbstractDateTimeTest.java line 73:
> 
>> 71: import org.junit.jupiter.api.Assertions;
>> 72: import org.junit.jupiter.api.Test;
>> 73: 
> 
> cosmetic: the blank line may better fit after junit imports

https://github.com/openjdk/jdk/pull/29071/commits/b3237311331c8a2c3c0863f7de6b93a89e853020 makes the rest of the eligible tests parameterized. After doing so, there was a test failure because some of the test class implementations provide values (which are instance variables) to `samples()` that are set during the `@beforeEach` methods. However, if the parametrized arguments are resolved before the value is set during the `@beforeEach` then it may be null during the test and fail.

To address this, the `samples()` methods were updated to use the tested values directly, rather than the re-usable instance variable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29071#discussion_r2669823356