RFR: 8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java

Roger Riggs rriggs at openjdk.org
Wed Jan 7 15:48:18 UTC 2026


On Tue, 6 Jan 2026 21:29:31 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Discovered in https://github.com/openjdk/jdk/pull/28911, two test methods in the base test class _AbstractDateTimeTest.java_ were not testing all the `TemporalAccessor`s from `samples()` correctly. This PR updates the test methods to become parametrized so that their assertions do not exit early.

looks good.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29071#pullrequestreview-3635520229


More information about the core-libs-dev mailing list