RFR: 8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java [v2]
Naoto Sato
naoto at openjdk.org
Wed Jan 7 20:06:35 UTC 2026
On Wed, 7 Jan 2026 19:34:16 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Discovered in https://github.com/openjdk/jdk/pull/28911, two test methods in the base test class _AbstractDateTimeTest.java_ were not testing all the `TemporalAccessor`s from `samples()` correctly. This PR updates the test methods to become parametrized so that their assertions do not exit early.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> parameterize the rest of tests and resolve setup conflicts
LGTM. Also good to see those `fail()` going away
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29071#pullrequestreview-3636597189
More information about the core-libs-dev
mailing list