RFR: 8374051: Incorrect parameterized testing of exceptions in AbstractDateTimeTest.java [v2]

Justin Lu jlu at openjdk.org
Wed Jan 7 19:34:16 UTC 2026


> Discovered in https://github.com/openjdk/jdk/pull/28911, two test methods in the base test class _AbstractDateTimeTest.java_ were not testing all the `TemporalAccessor`s from `samples()` correctly. This PR updates the test methods to become parametrized so that their assertions do not exit early.

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  parameterize the rest of tests and resolve setup conflicts

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29071/files
  - new: https://git.openjdk.org/jdk/pull/29071/files/9076b88a..b3237311

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29071&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29071&range=00-01

  Stats: 147 lines in 9 files changed: 8 ins; 45 del; 94 mod
  Patch: https://git.openjdk.org/jdk/pull/29071.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29071/head:pull/29071

PR: https://git.openjdk.org/jdk/pull/29071


More information about the core-libs-dev mailing list