RFR: 8373913: Refactor serialization tests to use JUnit [v2]
Roger Riggs
rriggs at openjdk.org
Mon Jan 12 20:26:04 UTC 2026
On Mon, 12 Jan 2026 18:53:54 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cleanup arglist and fix code style
>
> test/jdk/java/io/Serializable/serialFilter/SerialFilterFactoryTest.java line 182:
>
>> 180: @EnabledIf("isValidFilterFactory")
>> 181: @MethodSource("filterCases")
>> 182: @Order(1)
>
> This could be a relative order, such as `Order.DEFAULT - 1`, instead of 1 vs 99?
I haven't found any documentation of Order.DEFAULT indicating its recommended usage.
Nor any existing usages in OpenJDK.
Its value is a very large positive number. 0x3fffffff about 1/2 way to Integer.MAX_VALUE
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2683790748
More information about the core-libs-dev
mailing list