RFR: 8373913: Refactor serialization tests to use JUnit [v2]
Naoto Sato
naoto at openjdk.org
Mon Jan 12 21:06:10 UTC 2026
On Mon, 12 Jan 2026 20:22:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> test/jdk/java/io/Serializable/serialFilter/SerialFilterFactoryTest.java line 182:
>>
>>> 180: @EnabledIf("isValidFilterFactory")
>>> 181: @MethodSource("filterCases")
>>> 182: @Order(1)
>>
>> This could be a relative order, such as `Order.DEFAULT - 1`, instead of 1 vs 99?
>
> I haven't found any documentation of Order.DEFAULT indicating its recommended usage.
> Nor any existing usages in OpenJDK.
> Its value is a very large positive number. 0x3fffffff about 1/2 way to Integer.MAX_VALUE
I was just reading the JUnit doc that elements that are not annotated with `@Order` have the `DEFAULT` order value, thus giving the `testCase` method higher priority achieves what we want (with only one `@Order` annotation, instead of two). I am fine either way though
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2683894438
More information about the core-libs-dev
mailing list