RFR: 8376038: Refactor java/sql tests to use JUnit
Justin Lu
jlu at openjdk.org
Thu Jan 22 00:49:15 UTC 2026
Please review this PR which converts the JDBC TestNG tests to use JUnit.
This is mainly done using the automated tool in https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b, with some manual follow up commits. The testng folder is migrated to junit with the TEST.properties updated as well. Most changes are annotation updates and switching from testNG imports to JUnit. I decided to simplify cases of `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly in https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62.
Framework test stats before:
680 = 680 TestNG + 0 JUnit
Framework test stats after:
680 = 0 TestNG + 680 JUnit
-------------
Commit messages:
- Update copyright years
- Remove redundant test instance annotations from BaseTest children
- Clean up exception tests (lambdas + narrow scope)
- Simplify boolean value sources for base tests
- Rename testng folder to junit
- Update TEST.properties
- Apply conversion
Changes: https://git.openjdk.org/jdk/pull/29354/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=29354&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8376038
Stats: 3454 lines in 46 files changed: 1702 ins; 1634 del; 118 mod
Patch: https://git.openjdk.org/jdk/pull/29354.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29354/head:pull/29354
PR: https://git.openjdk.org/jdk/pull/29354
More information about the core-libs-dev
mailing list