RFR: 8376038: Refactor java/sql tests to use JUnit

Alan Bateman alanb at openjdk.org
Thu Jan 22 12:16:26 UTC 2026


On Thu, 22 Jan 2026 00:41:13 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which converts the JDBC TestNG tests to use JUnit.
> 
> This is mainly done using the automated tool in https://github.com/openjdk/jdk/commit/0cec3097aec02e72ccb6ebbf0b2b046220578d1b, with some manual follow up commits. The testng folder is migrated to junit with the TEST.properties updated as well. Most changes are annotation updates and switching from testNG imports to JUnit. I decided to simplify cases of `BaseTest.trueFalse()` to use booleans in a `ValueSource` directly in https://github.com/openjdk/jdk/commit/757e7966666d39748db2912b32ccf8b1df18bd62.
> 
> Framework test stats before:
> 680 = 680 TestNG + 0 JUnit
> 
> Framework test stats after:
> 680 = 0 TestNG + 680 JUnit

test/jdk/java/sql/driverModuleTests/DriverManagerModuleTests.java line 45:

> 43:  * via the service-provider loading mechanism.
> 44:  */
> 45: @TestInstance(TestInstance.Lifecycle.PER_CLASS)

Has migration replaces a data provider with a method source that is an instance method, when JUnit prefers a static method? I'm trying to understand why Lifecycle.PER_CLASS is needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29354#discussion_r2716655736


More information about the core-libs-dev mailing list