[crac] RFR: Improved open file descriptors tracking [v8]

Radim Vansa duke at openjdk.org
Wed Apr 19 12:15:28 UTC 2023


On Tue, 18 Apr 2023 17:15:51 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   On exception, invoke afterRestore on throwing Context, too.
>
> src/java.base/share/classes/jdk/crac/LoggerContainer.java line 9:
> 
>> 7:  * Therefore, we isolate the logger into a subclass and initialize lazily.
>> 8:  */
>> 9: public class LoggerContainer {
> 
> This should be package private at least.

It's not package private as I meant to create one logger for all things CRaC, including logging in one of the implementation packages. I could probably move that to `jdk.crac.impl` or `jdk.internal.crac`.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/43#discussion_r1171247591


More information about the crac-dev mailing list