[crac] RFR: Improved open file descriptors tracking [v8]

Radim Vansa duke at openjdk.org
Fri Apr 21 09:04:19 UTC 2023


On Tue, 18 Apr 2023 17:25:09 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   On exception, invoke afterRestore on throwing Context, too.
>
> src/java.base/share/classes/jdk/crac/impl/AbstractContextImpl.java line 31:
> 
>> 29: import java.util.concurrent.locks.ReentrantLock;
>> 30: 
>> 31: public abstract class AbstractContextImpl<R extends Resource, P> extends Context<R> {
> 
> `P` is not used anymore.
> 
> The semantic of this class is being changed significantly, as well as implementation. It would be very nice to extract these modifications into a separate PR with a more clear desription of the reason of the change,  tests, etc.

Done in https://github.com/openjdk/crac/pull/60

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/43#discussion_r1173527025


More information about the crac-dev mailing list