[crac] RFR: Fix builds
    Anton Kozlov 
    akozlov at openjdk.org
       
    Mon Aug 14 13:05:59 UTC 2023
    
    
  
On Sun, 13 Aug 2023 12:22:04 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
>> Fix builds in vairous configurations
>
> src/hotspot/cpu/s390/vm_version_s390.hpp line 571:
> 
>> 569: 
>> 570:   // No _features_names[] available on this CPU.
>> 571:   static void insert_features_names(char* buf, size_t buflen, unsigned long features[] = _features) {}
> 
> I do not see a reason for this change. How to test the s390 build?
>From the line 123 from this file --  _features is 
  static unsigned long _features[_features_buffer_len];
The build is tested in GHA https://github.com/AntonKozlov/crac/actions/runs/5841005695/job/15841780175
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/104#discussion_r1293408702
    
    
More information about the crac-dev
mailing list