[crac] RFR: Fix builds

Anton Kozlov akozlov at openjdk.org
Mon Aug 14 13:06:01 UTC 2023


On Mon, 14 Aug 2023 12:42:12 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> src/hotspot/cpu/s390/vm_version_s390.hpp line 571:
>> 
>>> 569: 
>>> 570:   // No _features_names[] available on this CPU.
>>> 571:   static void insert_features_names(char* buf, size_t buflen, unsigned long features[] = _features) {}
>> 
>> I do not see a reason for this change. How to test the s390 build?
>
> From the line 123 from this file --  _features is 
> 
>   static unsigned long _features[_features_buffer_len];
> 
> 
> The build is tested in GHA https://github.com/AntonKozlov/crac/actions/runs/5841005695/job/15841780175

Here the failure before the change: https://github.com/jankratochvil/crac/actions/runs/5854032342/job/15870802152

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/104#discussion_r1293412644


More information about the crac-dev mailing list