[crac] RFR: 8272472: StackGuardPages test doesn't build with glibc 2.34
Radim Vansa
duke at openjdk.org
Thu Feb 2 09:19:26 UTC 2023
On Thu, 1 Dec 2022 11:53:29 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> [8272472](https://bugs.openjdk.org/browse/JDK-8272472): StackGuardPages test doesn't build with glibc 2.34
>>
>> ../test/hotspot/jtreg/runtime/StackGuardPages/exeinvoke.c: In function 'set_signal_handler':
>> ../test/hotspot/jtreg/runtime/StackGuardPages/exeinvoke.c:72:15: error: storage size of 'altstack' isn't constant
>> 72 | static char altstack[SIGSTKSZ];
>> | ^~~~~~~~
>
> I'm not sure about this. The change was made for 18 and backported to JDK17.0.2. Instead of this, I'd prefer to continue CRaC development on JDK17u [1] or on openjdk/jdk master, to avoid backporting changes useful in general. Maintaining both will create some overhead though.
>
> [1] https://mail.openjdk.org/pipermail/crac-dev/2022-May/000230.html
@AntonKozlov So what's the plan to get CRaC builiding with new glibc? Should I create a PR to merge in the most recent jdk17u-dev?
-------------
PR: https://git.openjdk.org/crac/pull/37
More information about the crac-dev
mailing list