[crac] RFR: Handle open file descriptors with configurable policies [v14]

Radim Vansa rvansa at openjdk.org
Wed Jul 19 10:22:15 UTC 2023


On Wed, 19 Jul 2023 10:09:54 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix windows tests
>
> src/java.base/share/classes/java/io/FileDescriptor.java line 115:
> 
>> 113:                     }
>> 114:                 }
>> 115:                 String regex = params.get("regex");
> 
> Should it be `"descriptionRegex"`? as now it may appear appear the FD value will be matched as well.

FD value is a number, would you think of applying a regex on that?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/69#discussion_r1267873053


More information about the crac-dev mailing list