[crac] RFR: Handle open file descriptors with configurable policies [v14]
Anton Kozlov
akozlov at openjdk.org
Wed Jul 19 11:56:08 UTC 2023
On Wed, 19 Jul 2023 10:19:39 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/java.base/share/classes/java/io/FileDescriptor.java line 115:
>>
>>> 113: }
>>> 114: }
>>> 115: String regex = params.get("regex");
>>
>> Should it be `"descriptionRegex"`? as now it may appear appear the FD value will be matched as well.
>
> FD value is a number, would you think of applying a regex on that?
It was not clear what part of the `FileDescriptor 2: character: /dev/pts/43` is matched. If that is not evident for me only, OK.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/69#discussion_r1267963638
More information about the crac-dev
mailing list