[crac] RFR: Adapted some FileDescriptor tests for Win [v5]

Roman Marchenko rmarchenko at openjdk.org
Tue Jul 25 08:00:10 UTC 2023


On Tue, 25 Jul 2023 07:25:06 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moving macro outside func to make it clearer
>
> src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java line 271:
> 
>> 269: 
>> 270:     @Override
>> 271:     public void beforeCheckpoint(Context<? extends Resource> context) throws Exception {
> 
> It seems strange windows has it's own JarFileFactory, mostly duplicating a similar one. I'm fine with the current implementation, but it also seems possible to refactor and extract a single common resource implementation for windows and linux.

Could we do it after JDK version upgrade?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/91#discussion_r1273149172


More information about the crac-dev mailing list