[crac] RFR: Adapted some FileDescriptor tests for Win [v5]

Roman Marchenko rmarchenko at openjdk.org
Tue Jul 25 08:44:13 UTC 2023


On Tue, 25 Jul 2023 07:25:49 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moving macro outside func to make it clearer
>
> test/jdk/jdk/crac/fileDescriptors/OpenFileDetectionTest.java line 48:
> 
>> 46:         cp.outputAnalyzer()
>> 47:                 .shouldHaveExitValue(1)
>> 48:                 .shouldMatch("CheckpointOpenFileException: filename1.txt") // RandomAccessFile should have the expected format
> 
> Waiting for test results, don't we have absolute file path on linux?

No, the file names used in exception messages are the same as the names used to open files even if we used something like `./mydir/../filename`, at least for RandomAccessFile and FileInputStream classes. With a small note though, on Linux openeing `./mydir/../filename` file will produce the same string, but on Windows it will produce a string with backslashes - `.\\mydir\..\\filename`

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/91#discussion_r1273201685


More information about the crac-dev mailing list