[crac] RFR: Introduce per-Priority Context with different policies [v5]

Anton Kozlov akozlov at openjdk.org
Tue Jun 6 16:41:56 UTC 2023

On Wed, 31 May 2023 08:57:08 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> A follow-up work for #60:
>> * Each priority now has a dedicated context, so contextes may provide different policies.
>> * the Global Context reverted from BlockingOrderedContext to OrderedContext, as that may have a huge impact on users. Probably we'll want to expose blocking/criticalUnorderd context along the global one, or at some point expose an implementation. But this is also out of scope of the PR.
>> * hierachy of the Context implementations are cleaned up a bit [2]
>> The JDKContext is now just a holder of ClaimedFDs, I'll address this in a follow-up that depends on this Context follow-up.
>> [1] https://github.com/openjdk/crac/pull/60#issuecomment-1545588281
>> [2] https://github.com/openjdk/crac/pull/60#discussion_r1185510445
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>   Update

You get me right. Meanwhile I had change to use contextes with the blocking policies, and in the current form the auto-deadlock fires too often. I was assuming deadlock is fine, once it a rare edge case in the JDK internals. But as the Global Context implementation, blocking context with auto-deadlock possibility is not acceptable IMO. We unlikely want to offer such to implementation to users. So definetely, this is not the last change in the area :)


PR Comment: https://git.openjdk.org/crac/pull/74#issuecomment-1579098908

More information about the crac-dev mailing list