[crac] RFR: Introduce per-Priority Context with different policies [v5]
Anton Kozlov
akozlov at openjdk.org
Tue Jun 6 16:42:14 UTC 2023
On Mon, 5 Jun 2023 13:46:05 GMT, Radim Vansa <duke at openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update
>
> test/jdk/jdk/crac/ContextOrderTest.java line 147:
>
>> 145: thread.interrupt();
>> 146: thread.join(TimeUnit.NANOSECONDS.toMillis(deadline - System.nanoTime()));
>> 147: if (thread.getState() == Thread.State.WAITING) {
>
> I think you wanted to remove printing the stack traces here, too.
Let's have it there. This is on the failure path, so this won't appear until the failure. And everytime the failure happens, it's really required to know what is the stack trace of the thread that does not respond to the interruption.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/74#discussion_r1219959425
More information about the crac-dev
mailing list