[crac] RFR: Use special class for exception aggregates [v7]
Anton Kozlov
akozlov at openjdk.org
Thu Jun 8 09:26:21 UTC 2023
On Thu, 8 Jun 2023 06:35:45 GMT, Radim Vansa <duke at openjdk.org> wrote:
>> Extracted non-essential changes from other PR.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Moved exception after native failure
Could you please update the PR titile to match the new content?
src/java.base/share/classes/jdk/crac/CheckpointException.java line 36:
> 34:
> 35: /**
> 36: * Creates a {@code CheckpointException}.
I probably misclicked "Add comment",
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Throwable.html#%3Cinit%3E(java.lang.String,java.lang.Throwable,boolean,boolean):
> Subclasses of Throwable should document any conditions under which suppression is disabled and document conditions under which the stack trace is not writable.
The javadoc should specify the stack trace is not writeable, here and for other exceptions
-------------
PR Review: https://git.openjdk.org/crac/pull/64#pullrequestreview-1469403293
PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1222706815
More information about the crac-dev
mailing list