[crac] RFR: Make CheckpointException/RestoreException aggregate-only [v7]

Radim Vansa duke at openjdk.org
Thu Jun 8 11:50:36 UTC 2023

On Thu, 8 Jun 2023 09:23:27 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>   Moved exception after native failure
> src/java.base/share/classes/jdk/crac/CheckpointException.java line 36:
>> 34: 
>> 35:     /**
>> 36:      * Creates a {@code CheckpointException}.
> I probably misclicked "Add comment",
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/Throwable.html#%3Cinit%3E(java.lang.String,java.lang.Throwable,boolean,boolean):
>> Subclasses of Throwable should document any conditions under which suppression is disabled and document conditions under which the stack trace is not writable.
> The javadoc should specify the stack trace is not writeable, here and for other exceptions

Updated. I've also made those classes final to prevent subclassing with a specific meaning - the actual information should be in the suppressed exceptions.


PR Review Comment: https://git.openjdk.org/crac/pull/64#discussion_r1222925408

More information about the crac-dev mailing list