[crac] RFR: Fixing VMOptionsTest.java [v2]

Roman Marchenko rmarchenko at openjdk.org
Wed Jun 14 11:11:52 UTC 2023

> test/jdk/jdk/crac/VMOptionsTest.java fails in debug build because it expects that NativeMemoryTracking equals to"off", that is not true in debug build.
> Exception in thread "main" java.lang.RuntimeException: assertEquals: expected off to equal summary
>     at jdk.test.lib.Asserts.fail(Asserts.java:594)
>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:189)
>     at VMOptionsTest.exec(VMOptionsTest.java:60)
>     at jdk.test.lib.crac.CracTest.run(CracTest.java:155)
>     at jdk.test.lib.crac.CracTest.main(CracTest.java:87)
> This change fixes the issue by retrieving NMT value before checkpoint, and comparing later.

Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:

  Making the test conditions stable


  - all: https://git.openjdk.org/crac/pull/81/files
  - new: https://git.openjdk.org/crac/pull/81/files/4a27d68d..cb2fa67a

 - full: https://webrevs.openjdk.org/?repo=crac&pr=81&range=01
 - incr: https://webrevs.openjdk.org/?repo=crac&pr=81&range=00-01

  Stats: 30 lines in 2 files changed: 12 ins; 2 del; 16 mod
  Patch: https://git.openjdk.org/crac/pull/81.diff
  Fetch: git fetch https://git.openjdk.org/crac.git pull/81/head:pull/81

PR: https://git.openjdk.org/crac/pull/81

More information about the crac-dev mailing list