[crac] RFR: Fixing VMOptionsTest.java [v2]

[Radim Vansa]

On Wed, 14 Jun 2023 11:06:40 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> test/jdk/jdk/crac/VMOptionsTest.java fails in debug build because it expects that NativeMemoryTracking equals to"off", that is not true in debug build.
>> 
>> 
>> Exception in thread "main" java.lang.RuntimeException: assertEquals: expected off to equal summary
>>     at jdk.test.lib.Asserts.fail(Asserts.java:594)
>>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:189)
>>     at VMOptionsTest.exec(VMOptionsTest.java:60)
>>     at jdk.test.lib.crac.CracTest.run(CracTest.java:155)
>>     at jdk.test.lib.crac.CracTest.main(CracTest.java:87)
>> 
>> 
>> This change fixes the issue by retrieving NMT value before checkpoint, and comparing later.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Making the test conditions stable

LGTM. Out of curiosity, did you find any issues with using the same bean after restore?

-------------

Marked as reviewed by rvansa at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/crac/pull/81#pullrequestreview-1479123593