[crac] Integrated: Fixing VMOptionsTest.java

Roman Marchenko rmarchenko at openjdk.org
Thu Jun 15 07:27:34 UTC 2023


On Tue, 13 Jun 2023 13:11:32 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> test/jdk/jdk/crac/VMOptionsTest.java fails in debug build because it expects that NativeMemoryTracking equals to"off", that is not true in debug build.
> 
> 
> Exception in thread "main" java.lang.RuntimeException: assertEquals: expected off to equal summary
>     at jdk.test.lib.Asserts.fail(Asserts.java:594)
>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:205)
>     at jdk.test.lib.Asserts.assertEquals(Asserts.java:189)
>     at VMOptionsTest.exec(VMOptionsTest.java:60)
>     at jdk.test.lib.crac.CracTest.run(CracTest.java:155)
>     at jdk.test.lib.crac.CracTest.main(CracTest.java:87)
> 
> 
> This change fixes the issue by retrieving NMT value before checkpoint, and comparing later.

This pull request has now been integrated.

Changeset: bd9cf0be
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Anton Kozlov <akozlov at openjdk.org>
URL:       https://git.openjdk.org/crac/commit/bd9cf0bee8dacef44b29028fa0ad07b82b2e5783
Stats:     27 lines in 2 files changed: 11 ins; 0 del; 16 mod

Fixing VMOptionsTest.java

Reviewed-by: rvansa

-------------

PR: https://git.openjdk.org/crac/pull/81


More information about the crac-dev mailing list