[crac] RFR: Draft: Win/Mac build for CRaC

[Radim Vansa]

On Thu, 15 Jun 2023 13:35:39 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Draft: Win/Mac build for CRaC

I would probably have to do a more careful function-by-function comparison to check if any other changes were accidentally reverted.

src/hotspot/os/windows/os_windows.cpp line 6166:

> 6164: }
> 6165: 
> 6166: void VM_Crac::report_ok_to_jcmd_if_any() {

What happens when you execute JDK checkpoint from `jcmd` on Windows?

src/hotspot/share/runtime/os.cpp line 104:

> 102: 
> 103: // CRaC
> 104: static const char* _crengine = NULL;

Looks like you unintentionally reverted recent changes - search for `_crengine_args` and handling code.

src/hotspot/share/runtime/os.cpp line 2177:

> 2175: }
> 2176: 
> 2177: bool VM_Crac::is_claimed_fd(int fd) {

What about moving all this into `crac.cpp` rather than extending the already-long-enought `os.cpp`?

src/java.base/share/native/launcher/main.c line 155:

> 153:     sigact.sa_sigaction = sighandler;
> 154: 
> 155:     for (int sig = 1; sig <= 31; ++sig) {

Hardcoded constant?

src/java.base/windows/native/pauseengine/pauseengine.c line 36:

> 34: typedef int pid_t;
> 35: 
> 36: #define RESTORE_SIGNAL   (SIGRTMIN + 2)

Not used, I assume? I would still rather see the simplified engines sharing codebase.

-------------

PR Review: https://git.openjdk.org/crac/pull/82#pullrequestreview-1481675238
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231075475
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231081166
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231086673
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231093202
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231096407