[crac] RFR: Draft: Win/Mac build for CRaC

[Roman Marchenko]

On Thu, 15 Jun 2023 14:25:18 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Please ignore this PR for now.
>> Currently it is for testing purposes.
>
> I would probably have to do a more careful function-by-function comparison to check if any other changes were accidentally reverted.

@rvansa Hi,
You can ignore this PR for now. Currently it is for testing purposes.
I will remove "draft" mark when it is ready for review.

> src/hotspot/share/runtime/os.cpp line 104:
> 
>> 102: 
>> 103: // CRaC
>> 104: static const char* _crengine = NULL;
> 
> Looks like you unintentionally reverted recent changes - search for `_crengine_args` and handling code.

Thanks, I will check this

> src/hotspot/share/runtime/os.cpp line 2177:
> 
>> 2175: }
>> 2176: 
>> 2177: bool VM_Crac::is_claimed_fd(int fd) {
> 
> What about moving all this into `crac.cpp` rather than extending the already-long-enought `os.cpp`?

This is being performed now for another PR.

> src/java.base/share/native/launcher/main.c line 155:
> 
>> 153:     sigact.sa_sigaction = sighandler;
>> 154: 
>> 155:     for (int sig = 1; sig <= 31; ++sig) {
> 
> Hardcoded constant?

Yes, for different platforms there are no named constants with the same meaning. We could create one especially for CRaC.

-------------

PR Comment: https://git.openjdk.org/crac/pull/82#issuecomment-1593334909
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231235492
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231234419
PR Review Comment: https://git.openjdk.org/crac/pull/82#discussion_r1231232991