[crac] RFR: Support passing extra options in CREngine [v6]

Roman Marchenko rmarchenko at openjdk.org
Fri Jun 16 09:47:38 UTC 2023

On Thu, 15 Jun 2023 12:46:32 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> In addition to `-XX:CREngine=program` this adds support to `-XX:CREngine=program,--key,value,--anotherkey` that translates into invoking `program --key value --anotherkey`. Commas support escaping with a backslash.
>> This generic parameters support is utilized in `criuengine` that accepts `--verbosity` and `--log-file` options and relays them to `criu`.
> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>  - Merge branch 'crac' into engine_params
>  - Merge branch 'crac' into engine_params
>  - Use index var rather than looking up NULLs
>  - fixup
>  - Do not use dashes
>  - Merge branch 'crac' into engine_params
>  - Support passing extra options in CREngine

It seems like `jdk/crac/recursiveCheckpoint/Test.java` starts failing with timeout after this PR. Have you tested it locally?

As far as I see, the test is run with a comma added to CR engine name ("`-XX:CREngine=pauseengine,`")
And then, `pauseengine `cannot recognize `imagedir` name, because `arg[2]` is empty.

Can you reproduce this locally?


PR Comment: https://git.openjdk.org/crac/pull/63#issuecomment-1594413916

More information about the crac-dev mailing list