[crac] RFR: Support passing extra options in CREngine [v6]

[Roman Marchenko]

On Thu, 15 Jun 2023 12:46:32 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> In addition to `-XX:CREngine=program` this adds support to `-XX:CREngine=program,--key,value,--anotherkey` that translates into invoking `program --key value --anotherkey`. Commas support escaping with a backslash.
>> 
>> This generic parameters support is utilized in `criuengine` that accepts `--verbosity` and `--log-file` options and relays them to `criu`.
>
> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'crac' into engine_params
>  - Merge branch 'crac' into engine_params
>  - Use index var rather than looking up NULLs
>  - fixup
>  - Do not use dashes
>  - Merge branch 'crac' into engine_params
>  - Support passing extra options in CREngine

test/lib/jdk/test/lib/crac/CracBuilder.java line 338:

> 336:         cmd.add("-ea");
> 337:         if (engine != null) {
> 338:             String engArgs = engineArgs == null ? "" : "," + Arrays.stream(engineArgs)

I suppose `engineArgs == null` should be replaced with something like `engineArgs == null || 0 == engineArgs.length`

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/63#discussion_r1232051616