[crac] RFR: Support passing extra options in CREngine [v6]

[Radim Vansa]

On Fri, 16 Jun 2023 10:05:45 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> test/lib/jdk/test/lib/crac/CracBuilder.java line 338:
>> 
>>> 336:         cmd.add("-ea");
>>> 337:         if (engine != null) {
>>> 338:             String engArgs = engineArgs == null ? "" : "," + Arrays.stream(engineArgs)
>> 
>> I suppose `engineArgs == null` should be replaced with something like `engineArgs == null || 0 == engineArgs.length`
>
> You're right, I must have had something cached because when I re-ran the test it was passing... until I added some debug logs to confirm what you're seeing. I'll file a fix in a sec.

Filed https://github.com/openjdk/crac/pull/83

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/63#discussion_r1232058111