[crac] RFR: Support passing extra options in CREngine [v6]

[Radim Vansa]

On Fri, 16 Jun 2023 10:04:34 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge branch 'crac' into engine_params
>>  - Merge branch 'crac' into engine_params
>>  - Use index var rather than looking up NULLs
>>  - fixup
>>  - Do not use dashes
>>  - Merge branch 'crac' into engine_params
>>  - Support passing extra options in CREngine
>
> test/lib/jdk/test/lib/crac/CracBuilder.java line 338:
> 
>> 336:         cmd.add("-ea");
>> 337:         if (engine != null) {
>> 338:             String engArgs = engineArgs == null ? "" : "," + Arrays.stream(engineArgs)
> 
> I suppose `engineArgs == null` should be replaced with something like `engineArgs == null || 0 == engineArgs.length`

You're right, I must have had something cached because when I re-ran the test it was passing... until I added some debug logs to confirm what you're seeing. I'll file a fix in a sec.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/63#discussion_r1232052834