[crac] RFR: PID adjustment on checkpoint [v3]
Roman Marchenko
rmarchenko at openjdk.org
Wed Jun 21 13:31:39 UTC 2023
On Wed, 21 Jun 2023 12:55:33 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Disabling the test for non-linux platforms
>
> src/java.base/share/native/launcher/main.c line 331:
>
>> 329: const int crac_min_pid = 0 < env_min_pid ? env_min_pid : crac_min_pid_default;
>> 330:
>> 331: if (getpid() <= crac_min_pid) {
>
> A nit: probably `getpid() < crac_min_pid`?
This should work for pid==1 as well.
The possible values for crac_min_pid are 1, 2, 3, ...
In case of `getpid() < crac_min_pid`, it needs to have an additional check.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237000098
More information about the crac-dev
mailing list