[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Tue Jun 27 09:04:37 UTC 2023


On Wed, 21 Jun 2023 13:25:01 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> src/java.base/share/native/launcher/main.c line 331:
>> 
>>> 329:         const int crac_min_pid = 0 < env_min_pid ? env_min_pid : crac_min_pid_default;
>>> 330: 
>>> 331:         if (getpid() <= crac_min_pid) {
>> 
>> A nit: probably `getpid() < crac_min_pid`?
>
> This should work for pid==1 as well. 
> The possible values for crac_min_pid are 1, 2, 3, ...
> In case of `getpid() < crac_min_pid`, it needs to have an additional check.

As we discussed this offline, now PID adjustment is not applied by default, it works only if CracMinPid option is set by an user. So 'fork & wait' now is applied for pid==1 or for PID adjustment.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1243389704


More information about the crac-dev mailing list