[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Wed Jun 21 13:58:40 UTC 2023

On Wed, 21 Jun 2023 12:50:37 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> src/java.base/share/native/launcher/main.c line 191:
>>> 189:     FILE *last_pid_file = fopen(last_pid_filename, "w");
>>> 190:     if (!last_pid_file) {
>>> 191:         perror("last_pid_file fopen");
>> Should we have this message printed, even if we can achieve it through spinning? Looks like a unnecessary noise when we're still 'fine'.
> This can be an error, as `ns_last_pid` is expected to exist and be openable.

In non-privileged containers, ns_last_pid cannot be even open for writing. So this message may be considered as a warning, or info, or suppressed at all as Radim suggested.


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237045021

More information about the crac-dev mailing list