[crac] RFR: PID adjustment on checkpoint [v3]

Anton Kozlov akozlov at openjdk.org
Wed Jun 21 13:31:37 UTC 2023

On Wed, 21 Jun 2023 08:17:41 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>   Disabling the test for non-linux platforms
> src/java.base/share/native/launcher/main.c line 191:
>> 189:     FILE *last_pid_file = fopen(last_pid_filename, "w");
>> 190:     if (!last_pid_file) {
>> 191:         perror("last_pid_file fopen");
> Should we have this message printed, even if we can achieve it through spinning? Looks like a unnecessary noise when we're still 'fine'.

This can be an error, as `ns_last_pid` is expected to exist and be openable.


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1236950495

More information about the crac-dev mailing list