[crac] RFR: PID adjustment on checkpoint [v3]

[Anton Kozlov]

On Wed, 21 Jun 2023 13:32:28 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> src/java.base/share/native/launcher/main.c line 209:
>> 
>>> 207:             perror("waitpid last pid");
>>> 208:             break;
>>> 209:         }
>> 
>> Can we drop this completely and rely on wait_for_children() below in the control flow?
>
> Sure, however, will it be OK if we create hundreds or thousands of child processes at the same time, even if they exit soon?

Performance-wise, it looks even better to collect them after java has started execution. But you're right, that will create a burst of short living processes. OK, probably this is a safer option.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237306617