[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Wed Jun 21 13:35:36 UTC 2023


On Wed, 21 Jun 2023 13:04:31 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Disabling the test for non-linux platforms
>
> src/java.base/share/native/launcher/main.c line 209:
> 
>> 207:             perror("waitpid last pid");
>> 208:             break;
>> 209:         }
> 
> Can we drop this completely and rely on wait_for_children() below in the control flow?

Sure, however, will it be OK if we create hundreds or thousands of child processes at the same time, even if they exist soon?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1237010834


More information about the crac-dev mailing list