[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Thu Jun 22 08:43:35 UTC 2023

On Wed, 21 Jun 2023 16:58:47 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> I wouldn't test what's in `/proc/sys/kernel/pid_max` explicitly, but if PID #N+1 is lower than PID #N we have probably overflowed and that's what we should detect, and fail gracefully.
> Got it, in case user has provided some big value. For spin_last_pid, yes, it makes a lot of sense to build some safety, like Radim's suggestion. Or to limit number of attempts e.g. by the value itself (it should not take more than min_pid attempts to get pid>min_pid).

Should Java fails if PID cannot be moved to a desired PID value? Or just warn and go on?


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1238201039

More information about the crac-dev mailing list