[crac] RFR: PID adjustment on checkpoint [v3]

Radim Vansa rvansa at openjdk.org
Thu Jun 22 12:32:41 UTC 2023

On Thu, 22 Jun 2023 08:40:27 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Got it, in case user has provided some big value. For spin_last_pid, yes, it makes a lot of sense to build some safety, like Radim's suggestion. Or to limit number of attempts e.g. by the value itself (it should not take more than min_pid attempts to get pid>min_pid).
> Should Java fail if PID cannot be moved to a desired PID value? Or just warn and go on?

If the value was explicitly set, I think it would be better to fail. When it's trying to get to PID 128 by default I think it is sufficient to warn the user **and** tell him that he could switch off the warning setting `-XX:CRMinPid=1`.


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1238459303

More information about the crac-dev mailing list