[crac] RFR: PID adjustment on checkpoint [v3]

Roman Marchenko rmarchenko at openjdk.org
Fri Jun 23 13:03:49 UTC 2023

On Wed, 21 Jun 2023 12:48:18 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> This is because of PID adjustment  happens before JVM inits, so to use JVM option we need to have JVM option parsing implemented in main.c (at least for one option), more complicated than it was done in parse_checkpoint(). That is why I've decided to use env var instead. ~~OTOH maybe it worth considering moving PID adjustment & forking implementation to java.c, closer to JVM_Init call.~~ But no, option parsing is performed in JavaMain, running in a separate thread. This is not convenient for fork'ing.
> I would prefer -XX option as well. E.g. -XX:NativeMemoryTracking= is also handled in the launcher. Although in this case the option won't be handled in JVM at all, I think providing a common interface is better, since the option is expected to be changed in some product use-cases.

Implemented -XX:CRaCMinPid option


PR Review Comment: https://git.openjdk.org/crac/pull/86#discussion_r1239785664

More information about the crac-dev mailing list