[crac] RFR: Add CRaC-specific tests to GHA [v5]
Anton Kozlov
akozlov at openjdk.org
Tue Mar 7 14:33:27 UTC 2023
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Tue, 7 Mar 2023 12:10:56 GMT, Radim Vansa <duke at openjdk.org> wrote:
>> Existing GitHub Actions run test tier1 but since most changes in this project focus on the CRaC capabilities we should run them in an automated fashion, too.
>> Right now the tests are mostly failing: this should be addressed in https://github.com/openjdk/crac/pull/47
>
> Radim Vansa has updated the pull request incrementally with 16 additional commits since the last revision:
>
> - Finally fix ResolveTest
> - Add seemingly non-vital logs
> - Revert all debug info and hope for the best
> - what's wrong with cppath
> - Fix path
> - fix path
> - Fix criu SHA256
> - Print dump log
> - Use newer criu
> - Debug failing ResolveTest in GHA
> - ... and 6 more: https://git.openjdk.org/crac/compare/04996e37...1f9645ee
test/jdk/jdk/crac/java/net/InetAddress/ResolveTest.java line 105:
> 103: // not be able to restore the process.
> 104: // This workaround should not be necessary when https://github.com/openjdk/crac/pull/46
> 105: // is integrated.
I propose to wait until #46 is integrated and remove the mention (and workaround)
test/jdk/jdk/crac/java/net/InetAddress/ResolveTest.java line 107:
> 105: // is integrated.
> 106: List<String> javaCmd = new ArrayList<>();
> 107: javaCmd.addAll(Arrays.asList("/jdk/bin/java", "-cp", "/test-classes/", "-XX:CRaCCheckpointTo=/cr"));
This looks belonging to #50. Could this be the reason for strange failures of this test I've reported there?
-------------
PR: https://git.openjdk.org/crac/pull/48
More information about the crac-dev
mailing list