[crac] RFR: Add CRaC-specific tests to GHA [v5]

Radim Vansa duke at openjdk.org
Tue Mar 7 14:37:31 UTC 2023


On Tue, 7 Mar 2023 14:23:50 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with 16 additional commits since the last revision:
>> 
>>  - Finally fix ResolveTest
>>  - Add seemingly non-vital logs
>>  - Revert all debug info and hope for the best
>>  - what's wrong with cppath
>>  - Fix path
>>  - fix path
>>  - Fix criu SHA256
>>  - Print dump log
>>  - Use newer criu
>>  - Debug failing ResolveTest in GHA
>>  - ... and 6 more: https://git.openjdk.org/crac/compare/04996e37...1f9645ee
>
> test/jdk/jdk/crac/java/net/InetAddress/ResolveTest.java line 105:
> 
>> 103:         // not be able to restore the process.
>> 104:         // This workaround should not be necessary when https://github.com/openjdk/crac/pull/46
>> 105:         // is integrated.
> 
> I propose to wait until #46 is integrated and remove the mention (and workaround)

I would integrate code when it's ready reagardless of other PRs (haven't actually checked if this works with #46). This code will be anyway rewritten with #50

-------------

PR: https://git.openjdk.org/crac/pull/48


More information about the crac-dev mailing list