[crac] RFR: Improved open file descriptors tracking [v4]

[Radim Vansa]

On Mon, 13 Mar 2023 14:03:52 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/crac' into newfd
>>  - Use descriptor access rather than extending API
>>  - 8272472: StackGuardPages test doesn't build with glibc 2.34
>>    
>>    Backport-of: f77a1a156f3da9068d012d9227c7ee0fee58f571
>>  - Empty commit to trigger GHA
>>  - Drop native FDs tracking
>>  - Avoid claiming invalid FileDescriptor
>>  - Whitelist RandomAccessFile opening classpath files
>>    
>>    This is a workaround for some frameworks opening classpath files in
>>    a non-standard way.
>>  - Add tracking of FD origin
>>  - Track FileDescriptors closed by NIO
>>  - Track native FDs from EPoll
>>  - ... and 6 more: https://git.openjdk.org/crac/compare/6a0834b4...9b5e7edd
>
> src/java.base/share/classes/jdk/crac/Core.java line 138:
> 
>> 136:             fdArr[i] = claimedPairs.get(i).getKey();
>> 137:             objArr[i] = claimedPairs.get(i).getValue();
>> 138:             System.out.printf("%d %s\n", fdArr[i], objArr[i]);
> 
> Left-over from a debugging apparently

I am not so sure about that; the `objArr` is later ignored by the `VM_Crac` so I thought this it the place that should report open FDs, even though claimed by Java.

-------------

PR: https://git.openjdk.org/crac/pull/43