[crac] RFR: Improved open file descriptors tracking [v4]

Anton Kozlov akozlov at openjdk.org
Mon Mar 20 13:46:49 UTC 2023


On Mon, 20 Mar 2023 09:56:02 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/crac/Core.java line 138:
>> 
>>> 136:             fdArr[i] = claimedPairs.get(i).getKey();
>>> 137:             objArr[i] = claimedPairs.get(i).getValue();
>>> 138:             System.out.printf("%d %s\n", fdArr[i], objArr[i]);
>> 
>> Left-over from a debugging apparently
>
> I am not so sure about that; the `objArr` is later ignored by the `VM_Crac` so I thought this it the place that should report open FDs, even though claimed by Java.

I see, reporting here could be useful, but then it'd better use a Logger or something like that. BTW this was implemented in ad-hoc manner in https://github.com/openjdk/crac/pull/38/files, these should be unified.

-------------

PR: https://git.openjdk.org/crac/pull/43


More information about the crac-dev mailing list