[crac] RFR: Add CRaC-specific tests to GHA [v7]
Anton Kozlov
akozlov at openjdk.org
Fri Mar 24 08:24:05 UTC 2023
On Thu, 23 Mar 2023 15:21:53 GMT, Radim Vansa <duke at openjdk.org> wrote:
>> Existing GitHub Actions run test tier1 but since most changes in this project focus on the CRaC capabilities we should run them in an automated fashion, too.
>> Right now the tests are mostly failing: this should be addressed in https://github.com/openjdk/crac/pull/47
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Let ReseedTest use stdout rather than exit codes
>
> There was a 1:256 chance of test randomly failing because the random
> generators produced the same number, despite differently seeded.
test/jdk/jdk/crac/SecureRandom/ReseedTest.java line 75:
> 73:
> 74: System.out.println(sr.nextInt());
> 75: System.exit(0);
This change will also help when something is wrong with the restore, the previous version might confuse that situation with legitimate return with non-zero error.
On the second thought, could you extract this into a separate PR?
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/48#discussion_r1147247593
More information about the crac-dev
mailing list