[crac] RFR: Add CRaC-specific tests to GHA [v7]
Radim Vansa
duke at openjdk.org
Fri Mar 24 10:23:09 UTC 2023
On Fri, 24 Mar 2023 08:21:27 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Let ReseedTest use stdout rather than exit codes
>>
>> There was a 1:256 chance of test randomly failing because the random
>> generators produced the same number, despite differently seeded.
>
> test/jdk/jdk/crac/SecureRandom/ReseedTest.java line 75:
>
>> 73:
>> 74: System.out.println(sr.nextInt());
>> 75: System.exit(0);
>
> This change will also help when something is wrong with the restore, the previous version might confuse that situation with legitimate return with non-zero error.
>
> On the second thought, could you extract this into a separate PR?
If you promise me that you'll integrate right away, I can :)
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/48#discussion_r1147384676
More information about the crac-dev
mailing list